-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45187/#review124932
-----------------------------------------------------------


Fix it, then Ship it!





ambari-web/app/messages.js (line 1595)
<https://reviews.apache.org/r/45187/#comment187627>

    Remove the last "should."


- Alejandro Fernandez


On March 23, 2016, 12:06 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45187/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 12:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
> Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15520
>     https://issues.apache.org/jira/browse/AMBARI-15520
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add more warning on Pause button saying no topology changes.
> 
> Really need to warn folks on not making any add hosts/RM HA/others.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js 433834c 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> f1189a3 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 
> 6ec273c 
> 
> Diff: https://reviews.apache.org/r/45187/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 10488 tests complete (10 seconds)
> 121 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to