-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45208/#review125019
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 (line 347)
<https://reviews.apache.org/r/45208/#comment187769>

    Could `allMode` be renamed to something more self explanitory.  Maybe 
`recursive` and then reverse the logic as needed.



ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 (line 361)
<https://reviews.apache.org/r/45208/#comment187770>

    You might want to reverse the clauses here since the boolean check is 
faster than the `contains` check and mail fail first.


- Robert Levas


On March 23, 2016, 7:45 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45208/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15383
>     https://issues.apache.org/jira/browse/AMBARI-15383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cleanup LDAP sync process:
> - speedup sync with "--all" (do not check nested groups recursively...ambari 
> gather all of the groups first, and it's enough to just process them 
> sequentially)
> - fixing issue: uppercase member attributes (in ambari.properties) don't work 
> well with the queries
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  75df9cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  ffff3ea 
> 
> Diff: https://reviews.apache.org/r/45208/diff/
> 
> 
> Testing
> -------
> 
> Testing is in progress...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to