> On March 23, 2016, 9:11 p.m., Yusaku Sako wrote: > > How are we handling errors? Seems like we chain a bunch of calls. The > > user would need to see what went wrong. > > Also, can we get into partial failure scenarios?
>> How are we handling errors? We are using App.ajax coded endpoint which has a default failure handler for server errors: https://github.com/apache/ambari/blob/trunk/ambari-web/app/utils/ajax/ajax.js#L3054 >> Also, can we get into partial failure scenarios? I don't see that happening in usual scenario but might happen for any unknown reason if any one of the API fails, in which case popup from error handler will be shown with error message and ajax chain for the APIs will be broken from that point. - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45247/#review125132 ----------------------------------------------------------- On March 23, 2016, 8:58 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45247/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 8:58 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-15539 > https://issues.apache.org/jira/browse/AMBARI-15539 > > > Repository: ambari > > > Description > ------- > > Capacity scheduler will be changed as part of saving Hive configs related to > adding/deleting Hive Interactive Server. So YARN Queue has to be refreshed > before issuing Hive Interactive Server Start/Delete command > > > Diffs > ----- > > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 7857411 > > Diff: https://reviews.apache.org/r/45247/diff/ > > > Testing > ------- > > Tested the patch on a cluster > Verified that all ambari-web unit tests passes with the patch: > > > 24653 tests complete (24 seconds) > 145 tests pending > > > Thanks, > > Jaimin Jetly > >
