----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45285/#review125247 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On March 24, 2016, 3:06 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45285/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 3:06 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-14842 > https://issues.apache.org/jira/browse/AMBARI-14842 > > > Repository: ambari > > > Description > ------- > > Ambari 2.2.1.1 comes with the following upstart patch: > <https://issues.apache.org/jira/browse/AMBARI-14842> > > This seems to break the Ambari upstart script in RHEL/CentOS6: > > > > [root@slave-01 ~]# cat /etc/redhat-release > CentOS release 6.7 (Final) > [root@slave-01 ~]# rpm -qa|grep upstart > upstart-0.6.5-13.el6_5.3.x86_64 > [root@slave-01 ~]# status ambari-agent > status: Unknown job: ambari-agent > [root@slave-01 ~]# ls -l /etc/init/ambari-agent.conf > -rwxr-xr-x 1 root root 1035 Mar 10 18:33 /etc/init/ambari-agent.conf > > > This is due to the following line present in /etc/init/ambari-agent.conf: > kill signal SIGKILL > > Apparently, the upstart version shipped with RHEL6 doesn't support the kill > feature. > > I'm not sure why this kill is required, as the ambari-server /etc/init/ambari- > server.conf doesn't contain it. > > Can we have this kill line removed please? Or a separate /etc/init/ambari- > agent.conf file only for RHEL6 without this kill line? > > IN ADDITION: > > * the upstart script is deployed even on RHEL/CentOS7, where there is no > upstart - it would be cleaner to only deploy the upstart script if upstart is > actually installed on the system... > * request for systemd configs for both ambari-agent and ambari-server, > since systemd is default in centos7 > A proposed patch is: <https://issues.apache.org/jira/browse/AMBARI-14526> > > > Diffs > ----- > > ambari-agent/etc/init/ambari-agent.conf 75c1b06 > ambari-agent/src/main/python/ambari_agent/ExitHelper.py 06dfadb > ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py f9d0e14 > ambari-agent/src/main/python/ambari_agent/main.py 22e2e4a > > Diff: https://reviews.apache.org/r/45285/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
