-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45297/
-----------------------------------------------------------

(Updated March 25, 2016, 10:56 a.m.)


Review request for Ambari, Jaimin Jetly, Sumit Mohanty, and Sid Wagle.


Changes
-------

Added the state of the component in the error log.


Bugs: AMBARI-15549
    https://issues.apache.org/jira/browse/AMBARI-15549


Repository: ambari


Description
-------

AMBARI-15549: Delete service - Unable to delete a service even when it's host 
components are in a removable state.

** Issue **:

Unable to delete a service when all host components are in INSTALLED state but 
service component is in STARTED state.

** Fix **:
Use only the host components state to determine if a service is removable or 
not.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 ed7659fda685fe2a30b3c622467422874d78d086 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
 0cc03b8410170a4a3b200852dd3adc9b7b281345 

Diff: https://reviews.apache.org/r/45297/diff/


Testing
-------

** 1. mvn clean install  **

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [7.857s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.036s]
[INFO] Ambari Web ........................................ SUCCESS [24.995s]
[INFO] Ambari Views ...................................... SUCCESS [1.121s]
[INFO] Ambari Admin View ................................. SUCCESS [6.780s]
[INFO] ambari-metrics .................................... SUCCESS [0.348s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.467s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.042s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.552s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.615s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.552s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [6.269s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.093s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [1.025s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:18.756s]
[INFO] Ambari Server ..................................... SUCCESS [2:32.742s]
[INFO] Ambari Functional Tests ........................... SUCCESS [2.584s]
[INFO] Ambari Agent ...................................... SUCCESS [23.745s]
[INFO] Ambari Client ..................................... SUCCESS [0.062s]
[INFO] Ambari Python Client .............................. SUCCESS [1.103s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.176s]
[INFO] Ambari Shell ...................................... SUCCESS [0.046s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.702s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.988s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5:19.603s
[INFO] Finished at: Thu Mar 24 09:56:01 PDT 2016
[INFO] Final Memory: 262M/1193M
[INFO] ------------------------------------------------------------------------

** 2. mvn test -DskipPythonTests -Dtest=ServiceResourceProviderTest **

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.controller.internal.ServiceResourceProviderTest
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.961 sec - in 
org.apache.ambari.server.controller.internal.ServiceResourceProviderTest

Results :

Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.669s
[INFO] Finished at: Thu Mar 24 09:58:43 PDT 2016
[INFO] Final Memory: 55M/1015M
[INFO] ------------------------------------------------------------------------

** 3. Manual tests **

* Deployed a VM with AMBARI METRIC SERVICE - service component 
METRICS_COLLECTOR on two hosts.
* Set the state of the component on each host to INSTALLED and the state of the 
service component to STARTED.
* Deletion of AMS was successful


Thanks,

Nahappan Somasundaram

Reply via email to