-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45343/
-----------------------------------------------------------

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Mahadev 
Konar, and Srimanth Gunturi.


Bugs: AMBARI-15589
    https://issues.apache.org/jira/browse/AMBARI-15589


Repository: ambari


Description
-------

Stack Advisor recommendation overrides installed slaves topology of installed 
services when a new service is added.
Steps to reproduce:
- Install a cluster with HDFS and HAWQ select HAWQSEGMENTs on hosts different 
from the recommended set of hosts
- Install any other service (HBASE). Error: On the assign slaves page, the 
HAWQSEGMENTs are checked according to recommendations and not according to the 
current host topology.

The patch attached to this JIRA would fix the following issues:
- Recommendation given during Add Service wizard should be a combination of 
current topology for installed services and recommendation for service that is 
to be installed.
- Adding a new service after adding HAWQ or PXF would checkbox the HAWQSEGMENTs 
and PXFs correctly even if the user has placed these components different from 
the layout provided by the recommendation.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
cbcc4cb 
  ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
6dd0b44 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 8ae32a1 

Diff: https://reviews.apache.org/r/45343/diff/


Testing
-------

Manually Tested.
Ran unit tests on all stack advisors.


Thanks,

Matt

Reply via email to