> On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 120 > > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line120> > > > > Lets open a follow up JIRA to avoid sleeping and tracking completion of > > the command.
https://hortonworks.jira.com/browse/BUG-55074 > On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 156 > > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line156> > > > > Why don't we move this function to hive service interactive? That seems > > to be the file for helper methods. Moved stop_llap and start_llap. > On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 160 > > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line160> > > > > We should uses Execute() here - e.g. > > Execute(stop_cmd, user=params.hive_user, timeout=30). It has several > > other construct to control runaway command, whether to wait for finish or > > not etc. Instead we can develop a check command to see if slider app is > > alive and use that to decide to call destroy or not. The status command can > > be used in the status() call as well. Done. Using Ececute(). status() fn. created within Hive will be based out of when 'slider status llap?' is enhanced. Put a TODO. - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45325/#review125555 ----------------------------------------------------------- On March 26, 2016, 4:27 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45325/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 4:27 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit > Mohanty. > > > Bugs: AMBARI-15573 > https://issues.apache.org/jira/browse/AMBARI-15573 > > > Repository: ambari > > > Description > ------- > > Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), > and (2). Associate the LLAP lifecycle to it. > > - Start of HSI : Create LLAP package, start LLAP and then start HSI. > - Stop: Stop HSI and then LLAP. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > f07b76f > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 3532efc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 8a4e7e6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 12cf336 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 6f05fbc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > a6e4a47 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json > 1e349a1 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > face571 > > Diff: https://reviews.apache.org/r/45325/diff/ > > > Testing > ------- > > Yes. > - 2.6: Installation, config, Start and Stop of Hive Server Interactive after > Hive Server Batch -> Works. > - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> > Works > - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along > with Hive Server Batch -> Works. > - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server > Interactive not present). > - > - Python UT : Passes. > - mvn clean test : ongoing. Will update. > > > Thanks, > > Swapan Shridhar > >