-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45379/#review125675
-----------------------------------------------------------




contrib/views/files/src/main/resources/ui/app/controllers/files.js (line 93)
<https://reviews.apache.org/r/45379/#comment188541>

    We dont need a separate condition when length is 1.



contrib/views/files/src/main/resources/ui/app/controllers/files.js (line 97)
<https://reviews.apache.org/r/45379/#comment188542>

    This can be written as:
    ```
    multiplePaths = entities.map((entity) => {
        return entity.get('path');
    });
    
    return multiplePaths.join(', ');
    ```


- DIPAYAN BHOWMICK


On March 28, 2016, 10:18 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45379/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 10:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15598
>     https://issues.apache.org/jira/browse/AMBARI-15598
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Introduce ember-cli-clipboard addon to the application and used the same 
> component to do the needful.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 9fc11b6 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 3e178bc 
>   contrib/views/files/src/main/resources/ui/package.json 8250489 
> 
> Diff: https://reviews.apache.org/r/45379/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Reply via email to