-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45395/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-15606
https://issues.apache.org/jira/browse/AMBARI-15606
Repository: ambari
Description
-------
ISSUE: Ambari API does not return HDFS RPC metrics based on ports (Example 8020
and 8040)
When creating Ambari Widget we don't see an option to monitor by port. Hence
the monitoring of Random port or aggregate doesn't give correct information
After the patch, ambari automatically replaces port number with the
corresponding suffix
client for the port specified in hdfs-site/dfs.namenode.rpc-address
datanode for the port specified in hdfs-site/dfs.namenode.servicerpc-address
healthcheck for the port specified in
hdfs-site/dfs.namenode.lifeline.rpc-address
Request/response example
{
"href" :
"http://10.2.2.22:1081/api/v1/clusters/c1/services/HDFS/components/NAMENODE?fields=host_components/metrics/rpc/*,host_components/metrics/runtime/*";,
"ServiceComponentInfo" : {
"cluster_name" : "c1",
"component_name" : "NAMENODE",
"service_name" : "HDFS"
},
"host_components" : [
{
"href" :
"http://10.2.2.22:1081/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components/NAMENODE";,
"HostRoles" : {
"cluster_name" : "c1",
"component_name" : "NAMENODE",
"host_name" : "c6401.ambari.apache.org"
},
"metrics" : {
"rpc" : {
"client" : {
"NumOpenConnections" : 0,
"ReceivedBytes" : 2508,
"RpcProcessingTime_avg_time" : 0.0,
"RpcProcessingTime_num_ops" : 12,
"RpcQueueTime_avg_time" : 0.0,
"RpcQueueTime_num_ops" : 12,
"SentBytes" : 408,
"callQueueLen" : 0,
"rpcAuthenticationFailures" : 0,
"rpcAuthenticationSuccesses" : 0,
"rpcAuthorizationFailures" : 0,
"rpcAuthorizationSuccesses" : 12
},
"datanode" : {
"NumOpenConnections" : 2,
"ReceivedBytes" : 3269926,
"RpcProcessingTime_avg_time" : 0.0,
"RpcProcessingTime_num_ops" : 6029,
"RpcQueueTime_avg_time" : 0.0,
"RpcQueueTime_num_ops" : 6029,
"SentBytes" : 248169,
"callQueueLen" : 0,
"rpcAuthenticationFailures" : 0,
"rpcAuthenticationSuccesses" : 0,
"rpcAuthorizationFailures" : 0,
"rpcAuthorizationSuccesses" : 288
}
},
"runtime" : {
"StartTime" : 1459170322047
}
}
}
]
}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
4b15b80
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
7747753
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
15d44b2
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
b883d2b
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
41da279
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
b0e2e7a
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
35ba605
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java
2beb462
Diff: https://reviews.apache.org/r/45395/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
