-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/#review125719
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On March 28, 2016, 5:21 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45390/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 5:21 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15602
>     https://issues.apache.org/jira/browse/AMBARI-15602
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The {{alert_definition}} table will be updated to include a nullable column 
> which represents the custom repeat/retry tolerance value. This value will 
> override that which is set in the {{cluster-env/alerts_repeat_tolerance}} 
> property.
> 
> {code}
> CREATE TABLE alert_definition (
>   definition_id BIGINT NOT NULL,
>   cluster_id BIGINT NOT NULL,
>   ...
>   repeat_tolerance SMALLINT,
>   repeat_tolerance_enabled TINYINT,
>   ...
>   PRIMARY KEY (definition_id),
>   FOREIGN KEY (cluster_id) REFERENCES clusters(cluster_id),
>   CONSTRAINT uni_alert_def_name UNIQUE(cluster_id,definition_name)
> );
> {code}
> 
> The scope of work includes:
> - SQL File changes
> - Entity changes
> - ResourceProvider changes to expose these values
> - UpgradeCatalog changes
> - Tests
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  08a708f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
>  b08935c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  38a3614 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f8c97ca 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b306c0a 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 37744f8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql eba1745 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> cad0a39 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 346af50 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e238a76 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7b2d797 
> 
> Diff: https://reviews.apache.org/r/45390/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to