-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45208/#review125834
-----------------------------------------------------------




ambari-server/conf/unix/log4j.properties (line 79)
<https://reviews.apache.org/r/45208/#comment188706>

    Why is this needed? The root logger already runs with INFO level.



ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 (line 93)
<https://reviews.apache.org/r/45208/#comment188707>

    Document what us this regexp used for.



ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
 (line 519)
<https://reviews.apache.org/r/45208/#comment188711>

    Can we just make the regexp to be case insensitive instead of using 
StringUtils.lowerCase?


- Sebastian Toader


On March 28, 2016, 10:23 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45208/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 10:23 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15383
>     https://issues.apache.org/jira/browse/AMBARI-15383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cleanup LDAP sync process:
> - speedup sync with "--all" (do not check nested groups recursively...ambari 
> gather all of the groups first, and it's enough to just process them 
> sequentially)
> - fixing issue: uppercase member attributes (in ambari.properties) don't work 
> well with the queries
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/log4j.properties ab3ea0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  c2bc22f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  75df9cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  ffff3ea 
> 
> Diff: https://reviews.apache.org/r/45208/diff/
> 
> 
> Testing
> -------
> 
> Testing is in progress
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to