> On March 29, 2016, 12:49 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java, > > lines 535-547 > > <https://reviews.apache.org/r/45169/diff/1/?file=1310660#file1310660line535> > > > > What exactly is the use case for marshalling back to the filesystem? > > Filesystem access is read-only when running Ambari as non-root, so this > > code will not work. If you are looking for merge-ordering or something to > > make an "uber upgrade pack", then that can be done at orchestration or keep > > it in-memory.
Hi Nate, the purpose was really for testing. I marshalled the results file back to the FS so I could compare the results with the original upgrade xml. - Tim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45169/#review125862 ----------------------------------------------------------- On March 22, 2016, 6:40 p.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45169/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 6:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-15388 > https://issues.apache.org/jira/browse/AMBARI-15388 > > > Repository: ambari > > > Description > ------- > > Currently the upgrade is defined as a series of xml files specific to the > current stack version and the target stack version. Each upgrade xml defines > the overall sequence of the upgrade and what needs to be done for each > service. It would both easier to maintain and easier to add new services, if > the services themselves could specify what should be done during their > upgrade. > > There are two ways to make these changes, the alternate approach would be to > only make the java changes and not split the upgrade xml files. This would > still allow new services to add themselves into the upgrade. The benefit of > this is that for the stack services you only have one upgrade xml file. The > problem with that is it is easier for a particular service to have > unintentional changes between upgrade xml files. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java > 9e2f997 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java > c552e41 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > b860731 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > 67d7fdb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java > 5cda422 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 440bd50 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 430114b > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 1b6cb8b > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/zookeeper.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > f1d3c82 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > d23c992 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 78bee7e > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > b1599ea > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > d826446 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hbase.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hdfs.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/hive.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/kafka.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/oozie.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/spark.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/configs/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 74453e7 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3/zookeeper.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 5d1520b > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > ed30846 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > 5fa0966 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > f71ef1a > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/hive.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/configs/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > fe05d91 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4/zookeeper.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > 4ad5d6d > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/accumulo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ambari-metrics.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/atlas.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/falcon.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/flume.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hbase.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hdfs.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/hive.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/kafka.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/knox.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/mahout.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/oozie.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/pig.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger-kms.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/ranger.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/slider.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/spark.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/sqoop.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/storm.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/tez.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/yarn.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4/zookeeper.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/45169/diff/ > > > Testing > ------- > > Manual testing so far. I have the code read the upgrade xml and all of its > service specific xml files, built the upgrade pack and then write the full > upgrade xml to disk and then compare the results to the original upgrade xml. > > This review is mostly for the design doc which is attached to the JIRA. Not > sure how to create a review board with a design doc instead of a patch file. > > > Thanks, > > Tim Thorpe > >
