> On March 29, 2016, 4:17 p.m., Jayush Luniya wrote: > > Ship It!
@Juanjo Please see my comments below. I noticed the issue after I +1'ed. Can you revise the patch? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125895 ----------------------------------------------------------- On March 24, 2016, 11:26 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45328/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-14451 > https://issues.apache.org/jira/browse/AMBARI-14451 > > > Repository: ambari > > > Description > ------- > > Featurize HDP specific logic from HDFS service > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 1d59d9d > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > d1343ec > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > 98f20e7 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py > 70b1970 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > 3c9c5c5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 3cdfda9 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > c5ae35e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 6f26b40 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py > d598840 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > acd10e8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py > c705fca > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 9fa3cd4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 209ac91 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > f96ac01 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > c626028 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > bb974f1 > > Diff: https://reviews.apache.org/r/45328/diff/ > > > Testing > ------- > > mvn clean test -DskipSurefireTests > > Found 1 error. It seems related to PXF and not to the patch: > > Failed tests: > ERROR: test_get_pxf_protocol_version > (test_alerts_api_status.TestAlertsApiStatus) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py", > line 51, in test_get_pxf_protocol_version > version = api_status._get_pxf_protocol_version() > TypeError: _get_pxf_protocol_version() takes exactly 1 argument (0 given) > > ---------------------------------------------------------------------- > Total run:928 > Total errors:1 > Total failures:0 > > > Thanks, > > Juanjo Marron > >
