-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45374/#review126084
-----------------------------------------------------------


Ship it!




I'm ok with that, but lets wait for one more +1

- Dmytro Sen


On Март 30, 2016, 2:02 д.п., Akira Ajisaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45374/
> -----------------------------------------------------------
> 
> (Updated Март 30, 2016, 2:02 д.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15588
>     https://issues.apache.org/jira/browse/AMBARI-15588
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If we want to rotate ambari-metrics-collector.out by logrotate (using 
> copytruncate option), we need to use ">>" instead of ">" not to keep the file 
> offset to write. If the offset is kept, null characters are padded in the new 
> file.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor
>  7464c55 
> 
> Diff: https://reviews.apache.org/r/45374/diff/
> 
> 
> Testing
> -------
> 
> Manually tested the patch and verified that the .out is rotated collectly.
> 
> 
> Thanks,
> 
> Akira Ajisaka
> 
>

Reply via email to