> On March 30, 2016, 2:05 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java,
> >  line 62
> > <https://reviews.apache.org/r/45208/diff/6/?file=1318881#file1318881line62>
> >
> >     `full` is never `null`?

No, during creation of DistinguishedName its handled, when the object/string in 
DistinguishedName is empty or null (with StringUtils.isBlank), because of that 
it will be enough to check: adapter has a DN attribute or not.  (it's safe 
because we use a cast on that)


> On March 30, 2016, 2:05 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java,
> >  line 60
> > <https://reviews.apache.org/r/45208/diff/6/?file=1318881#file1318881line60>
> >
> >     There seems to be a lot of room for NPEs to be thrown.  DO we know 
> > null's aren't returned from the various calls?

see comment below


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45208/#review126103
-----------------------------------------------------------


On March 30, 2016, 3:25 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45208/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15383
>     https://issues.apache.org/jira/browse/AMBARI-15383
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cleanup LDAP sync process:
> - speedup sync with "--all" (do not check nested groups recursively...ambari 
> gather all of the groups first, and it's enough to just process them 
> sequentially)
> - fixing issue: uppercase member attributes (in ambari.properties) don't work 
> well with the queries
> - check that user/group DN (which is processed) is out of the scope or not 
> based on the base DN
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java
>  ffebd45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  c2bc22f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
>  75df9cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariLdapUtilsTest.java
>  b2778ae 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  ffff3ea 
> 
> Diff: https://reviews.apache.org/r/45208/diff/
> 
> 
> Testing
> -------
> 
> Testing is in progress.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to