----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45549/#review126341 -----------------------------------------------------------
Fix it, then Ship it! The patch looks fine to me, but I'd recommend adding a unit test for this change. Thanks. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 2415) <https://reviews.apache.org/r/45549/#comment189316> This change looks fine to me, but I'd recommend adding a unit test to the BlueprintConfigurationProcessorTest, just to make sure this issue doesn't regress in the future. Thanks. - Robert Nettleton On March 31, 2016, 4:36 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45549/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 4:36 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-15653 > https://issues.apache.org/jira/browse/AMBARI-15653 > > > Repository: ambari > > > Description > ------- > > 31 Mar 2016 15:55:55,479 INFO [qtp-ambari-client-22] > AmbariManagementControllerImpl:1445 - Received a updateCluster request, > clusterId=null, clusterName=c1, securityType=null, request={ clusterName=c1, > clusterId=null, provisioningState=INSTALLED, securityType=null, > stackVersion=HDP-2.4, desired_scv=null, hosts=[] } > 31 Mar 2016 15:55:55,502 ERROR [pool-11-thread-1] TopologyManager:762 - > TopologyManager.ConfigureClusterTask: An exception occurred while attempting > to process cluster configs and set on cluster: > java.lang.IllegalArgumentException: Unable to update configuration > property 'atlas.rest.address' with topology information. Component > 'ATLAS_SERVER' is mapped to an invalid number of hosts '0'. > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$SingleHostTopologyUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1328) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:263) > at > org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:150) > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:760) > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:734) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > 31 Mar 2016 15:55:55,502 INFO [pool-2-thread-1] AsyncCallableService:111 > - Exception during task execution: > java.util.concurrent.ExecutionException: java.lang.Exception: > java.lang.IllegalArgumentException: Unable to update configuration property > 'atlas.rest.address' with topology information. Component 'ATLAS_SERVER' is > mapped to an invalid number of hosts '0'. > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:206) > at > org.apache.ambari.server.topology.AsyncCallableService.taskCompleted(AsyncCallableService.java:103) > at > org.apache.ambari.server.topology.AsyncCallableService.call(AsyncCallableService.java:74) > at > org.apache.ambari.server.topology.AsyncCallableService.call(AsyncCallableService.java:37) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.Exception: java.lang.IllegalArgumentException: > Unable to update configuration property 'atlas.rest.address' with topology > information. Component 'ATLAS_SERVER' is mapped to an invalid number of hosts > '0'. > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:766) > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:734) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > ... 3 more > Caused by: java.lang.IllegalArgumentException: Unable to update > configuration property 'atlas.rest.address' with topology information. > Component 'ATLAS_SERVER' is mapped to an invalid number of hosts '0'. > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor$SingleHostTopologyUpdater.updateForClusterCreate(BlueprintConfigurationProcessor.java:1328) > at > org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:263) > at > org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:150) > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:760) > ... 7 more > 31 Mar 2016 15:55:56,503 INFO [pool-11-thread-1] TopologyManager:746 - > TopologyManager.ConfigureClusterTask: Entering > 31 Mar 2016 15:55:56,508 WARN [pool-11-thread-1] > BlueprintConfigurationProcessor:1360 - The property 'atlas.rest.address' is > associated with the component 'ATLAS_SERVER' which isn't mapped to any host > group. This may affect configuration topology resolution. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 9cc7b13 > > Diff: https://reviews.apache.org/r/45549/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
