-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45518/
-----------------------------------------------------------

(Updated March 31, 2016, 9:35 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
-------

A couple of more important changes.

1. Change aggregator UPSERT statement to select > startTime and <= endTime 
instead of >=startTime and < endTime, since we do a right align of aggregated 
data.
2. Only Non Zero values should contribute to Counts during the insertion in 
METRIC_RECORD as well as time slicing for METRIC_AGGREGATE.


Bugs: AMBARI-15638
    https://issues.apache.org/jira/browse/AMBARI-15638


Repository: ambari


Description
-------

Sum Calculation is incorrect when the time range is more than 2 hrs.
This issue affects all metrics that are queried with the "sum" aggregator (with 
or without hostname being specified) for more than a 2hr time-range.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
 ce79b6f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 9354bc3 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java
 846ae92 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 e67a5b8 

Diff: https://reviews.apache.org/r/45518/diff/


Testing
-------

Manually tested. Unit tests pass.


Thanks,

Aravindan Vijayan

Reply via email to