> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py,
> >  line 132
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320298#file1320298line132>
> >
> >     Lets just use stack_name.upper() to set this for now and remove the HDP 
> > hardcoding.

Since HIVE was also using /usr/share/HDP-hive I thoughjt it could be a good 
idea to abstract it as a property.
But you are right, the path is not even an existing directory


> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> >     Let me check if this restriction for 2.2.1.0 is Oozie specific.

Maintained  for now in the new patch. Please, let me know if it needs to be 
edited


- Juanjo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------


On March 31, 2016, 2:50 a.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 2:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
>     https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  54fbb8e 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  974ddd7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  1c80663 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> ------------------------------------------------------------------------
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Reply via email to