-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45593/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg Nechiporenko,
Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15138
https://issues.apache.org/jira/browse/AMBARI-15138
Repository: ambari
Description
-------
Need an attribute "visibility" that can optionally be included in SCRIPT params.
1) If omitted, the param is shown in the UI
2) If set "visibility":"HIDDEN", the param is hidden in the UI
3) If set "visibility":"READ_ONLY", the param is shown in the UI but not
edtiable
"parameters": [
{
"name": "connection.timeout",
"display_name": "Connection Timeout",
"value": 5.0,
"type": "NUMERIC",
"description": "The maximum time before this alert is considered
to be CRITICAL",
"units": "seconds",
"threshold": "CRITICAL"
},
Diffs
-----
ambari-web/app/controllers/main/alerts/definition_configs_controller.js
a927b59
ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e
ambari-web/app/models/alerts/alert_definition.js a730572
ambari-web/app/templates/main/alerts/configs.hbs dff1b53
Diff: https://reviews.apache.org/r/45593/diff/
Testing
-------
Local ambari-web test passed.
25602 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang