> On April 1, 2016, 2:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java, > > line 251 > > <https://reviews.apache.org/r/45586/diff/2/?file=1322455#file1322455line251> > > > > Do both of these tests require internet connection and take up to 45 > > secs each?
That was just to make sure the load thread finishes before the test does (which makes all the assertions randomly false). Tests don't access the internet, they all use files (double checked, but didn't write that code). Will bump it down to 10s or so. > On April 1, 2016, 2:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, > > line 94 > > <https://reviews.apache.org/r/45586/diff/2/?file=1322448#file1322448line94> > > > > is show_available supposed to be a top-level param? Will fix. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126619 ----------------------------------------------------------- On April 1, 2016, 12:43 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45586/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 12:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-15652 > https://issues.apache.org/jira/browse/AMBARI-15652 > > > Repository: ambari > > > Description > ------- > > * Load additional information out of hdp_urlinfo.json that will load VDF from > a known location > * Merging these separate VDF into one representation due to Ambari structures > * Expose these available VDF via endpoint (included using established > OperatingSystem and Repository sub-resources) > * Allow creation of internal repo_version based on an available VDF > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java > 67d9439 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 0f09d94 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java > e637850 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > d1f8232 > > ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemRequest.java > 16136db > > ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java > cc9bb70 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 63f6b60 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java > b982583 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > a37364f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > 3ab5169 > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 0d87b68 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 50bc30f > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java > 0ad24fe > ambari-server/src/main/resources/version_definition.xsd 3c0399f > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > d729d2a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 58f00e9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java > efdf84e > > ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java > 707057f > ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json 37a6a60 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.4-123.xml > PRE-CREATION > contrib/version-builder/version_builder.py f209894 > > Diff: https://reviews.apache.org/r/45586/diff/ > > > Testing > ------- > > Manual. Automated: > > > Tests run: 4096, Failures: 0, Errors: 0, Skipped: 33 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 35:07.392s > [INFO] Finished at: Fri Apr 01 09:35:30 EDT 2016 > [INFO] Final Memory: 37M/754M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
