> On April 4, 2016, 7:17 p.m., Jayush Luniya wrote:
> > ambari-web/app/views/main/dashboard/widgets.js, line 481
> > <https://reviews.apache.org/r/45705/diff/1/?file=1325063#file1325063line481>
> >
> >     Surprised that this needs UI changes too. Why isnt alerts.json change 
> > sufficient for this? 
> >     
> >     Also these values need documentation.

Change to the alert.json is sufficient for the alert.

We have a main dashboard widget that shows no. of HAWQ Segments Live (similar 
to Datanodes Live). The dashboard widget is independent of the alert.
The change to the UI is to keep the thresholds of the dashboard widget similar 
to that of the alert thresholds so that users see the same color coding (Alert 
- CRITICAL RED when 25% or more segments are down AND Dashboard widget shows 
RED when less than 75% of segments are up)


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127007
-----------------------------------------------------------


On April 4, 2016, 2:48 p.m., Alexander Denissov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45705/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 2:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15693
>     https://issues.apache.org/jira/browse/AMBARI-15693
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ segment percentage alert critical threshold should be 25%
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 8da5beb 
>   ambari-web/app/views/main/dashboard/widgets.js 04be7bb 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 
> 
> Diff: https://reviews.apache.org/r/45705/diff/
> 
> 
> Testing
> -------
> 
> manual, ran python tests:
> 
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Reply via email to