----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45741/#review127084 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 5, 2016, 11:13 до полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45741/ > ----------------------------------------------------------- > > (Updated Квітень 5, 2016, 11:13 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15711 > https://issues.apache.org/jira/browse/AMBARI-15711 > > > Repository: ambari > > > Description > ------- > > When hosts are being mapped to a clusters (see > ClustersImpl.java:mapHostToCluster) it verifies if the OS type of the host > matches the OS types supported by the stack that is being deployed. > > If the OS type of the host is not supported than a warning message is logged > and an exception is thrown which is silently swallowed. > > > > > .... > if (!isOsSupportedByClusterStack(cluster, host)) { > String message = "Trying to map host to cluster where stack does > not" > + " support host's os type" + ", clusterName=" + clusterName > + ", clusterStackId=" + > cluster.getDesiredStackVersion().getStackId() > + ", hostname=" + hostname + ", hostOsFamily=" + > host.getOsFamily(); > LOG.warn(message); > throw new AmbariException(message); > } > ... > > > This message should be logged as ERROR to make easier troubleshooting as most > of the time people search for exceptions and ERRORs in the log when looking > into issues with cluster. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 6c68d0e > > Diff: https://reviews.apache.org/r/45741/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
