-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45743/#review127085
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On April 5, 2016, 12:07 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45743/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15666
>     https://issues.apache.org/jira/browse/AMBARI-15666
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As discussed...Need an attribute "visibility" that can optionally be included
> in SCRIPT params.
> 
> 1) If omitted, the param is shown in the UI  
> 2) If set "visibility":"hidden", the param is hidden in the UI  
> 3) If set "visibility":"readonly", the param is shown in the UI but not
> edtiable
> 
>     
>     
>     
>     "parameters": [
>                 {
>                   "name": "connection.timeout",
>                   "display_name": "Connection Timeout",
>                   "value": 5.0,
>                   "type": "NUMERIC",
>                   "description": "The maximum time before this alert is 
> considered to be CRITICAL",
>                   "units": "seconds",
>                   "threshold": "CRITICAL"
>                 },
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java
>  f67a135 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  2023a2b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b3241e0 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
> fc3e21f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> 2ff7069 
> 
> Diff: https://reviews.apache.org/r/45743/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to