-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45751/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15718
    https://issues.apache.org/jira/browse/AMBARI-15718


Repository: ambari


Description
-------

percentage number in the alerts' definition should be consistent. So all the
percentage parameter should have a percentage value (e.g. 20, 50, 80 or 120),
a type of "PERCENT" and a unit "%"  
Currently:  
1\. METRIC:  
1.1 NameNode Host CPU Utilization/Thresholds: 250  
Has units %. No type.  
2\. SCRIPT:  
2.1 Host Disk Usage (old ones): 0.8  
2.2 NameNode Heap Usage (Hourly) (new ones) : 200  
Has units %. Has type PERCENT  
3\. AGGREGATE:  
3.1 Percent DataNodes With Available Space: 0.3  
No units. No type.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
 950797c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 
cd6abad 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 b1f66af 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f603896 
  ambari-server/src/main/resources/alerts.json e584b2c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json
 1da4e24 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
8da5beb 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 
e2dffe3 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
d6f53cc 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
 71e34e6 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json 
f25d29b 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json 
6198a74 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/alerts.json
 d27fe02 
  ambari-server/src/main/resources/host_scripts/alert_disk_space.py b7a7038 

Diff: https://reviews.apache.org/r/45751/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Reply via email to