----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45772/#review127209 -----------------------------------------------------------
Ship it! ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java (line 48) <https://reviews.apache.org/r/45772/#comment190380> Can values be null ? ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java (line 245) <https://reviews.apache.org/r/45772/#comment190382> No need to braces. - Sid Wagle On April 5, 2016, 8:14 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45772/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 8:14 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15638 > https://issues.apache.org/jira/browse/AMBARI-15638 > > > Repository: ambari > > > Description > ------- > > 1. Including Zero values in METRIC_RECORD METRIC_COUNT. > 2. Fixing issue in TimelineMetricClusterAggregatorSecond > 3. Fixing issue in AVG() call in Phoenix query for higher level aggregates. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java > 126b3a3 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java > 67c463f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > e3030f6 > > Diff: https://reviews.apache.org/r/45772/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
