----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45786/#review127258 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 155) <https://reviews.apache.org/r/45786/#comment190479> I started with the functions that Swapan wrote and modified them slightly to be a bit shorter. - Alejandro Fernandez On April 6, 2016, 12:14 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45786/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 12:14 a.m.) > > > Review request for Ambari, Jaimin Jetly and Swapan Shridhar. > > > Bugs: AMBARI-15723 > https://issues.apache.org/jira/browse/AMBARI-15723 > > > Repository: ambari > > > Description > ------- > > LLAP needs to be independent of Hive Server Interactive, so must have a > Custom Command in order to restart it. > When Hive Server Interactive starts/stops, it must also perform the same > action for LLAP, so it must share the same method. > This request is to create the link in the UI and plug it into the python > methods. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml > 4842f32 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > e1c0c42 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py > 9f32d16 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 70b8921 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml > b434021 > ambari-web/app/controllers/main/service/item.js ef728d1 > ambari-web/app/messages.js 4cb02d9 > ambari-web/app/models/host_component.js d7dce6e > ambari-web/app/views/main/service/item.js 6fc5068 > ambari-web/test/views/main/service/item_test.js 9feb187 > > Diff: https://reviews.apache.org/r/45786/diff/ > > > Testing > ------- > > Verified that custom command works. > > Ran ambari web unit tests, > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 1393 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 39.553 s > [INFO] Finished at: 2016-04-05T17:13:17-07:00 > [INFO] Final Memory: 36M/3926M > [INFO] > ------------------------------------------------------------------------ > > > and python unit tests > > Total run:942 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >