-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45845/#review127571
-----------------------------------------------------------


Ship it!




Since it's a 2.4.0 ticket, please add unit tests before commit

- Dmytro Sen


On Апрель 6, 2016, 11:39 п.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45845/
> -----------------------------------------------------------
> 
> (Updated Апрель 6, 2016, 11:39 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15694
>     https://issues.apache.org/jira/browse/AMBARI-15694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When querying a large number of Hosts, AMS API returns a truncated set of 
> data-points. The number of data-points is
> Metrics service default result limit / no. of hosts
> 
> If the Metrics service default result limit is set to 15840 (current 
> default), then for 900 hosts, the data-points that will be returned for each 
> host will be 18.
> 
> FIX
> Take into account the hostnames requested also, while calculating calculating 
> result set size estimate.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  6a231c2 
> 
> Diff: https://reviews.apache.org/r/45845/diff/
> 
> 
> Testing
> -------
> 
> Manually tested all charts in Ambari Web in all time ranges.
> 
> Triggered exception message through Grafana.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to