-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45871/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-15761
https://issues.apache.org/jira/browse/AMBARI-15761
Repository: ambari
Description
-------
As an example, look at the following alert:
"APP_TIMELINE_SERVER": [
{
"name": "yarn_app_timeline_server_webui",
"label": "App Timeline Web UI",
"description": "This host-level alert is triggered if the App
Timeline Server Web UI is unreachable.",
"interval": 5,
"scope": "ANY",
"source": {
"type": "WEB",
"uri": {
"http":
"{{yarn-site/yarn.timeline-service.webapp.address}}/ws/v1/timeline",
"https":
"{{yarn-site/yarn.timeline-service.webapp.https.address}}/ws/v1/timeline",
"https_property": "{{yarn-site/yarn.http.policy}}",
"https_property_value": "HTTPS_ONLY",
"kerberos_keytab":
"{{yarn-site/yarn.timeline-service.http-authentication.kerberos.keytab}}",
"kerberos_principal":
"{{yarn-site/yarn.timeline-service.http-authentication.kerberos.principal}}",
"connection_timeout": 5.0
},
"reporting": {
"ok": {
"text": "HTTP {0} response in {2:.3f}s"
},
"warning":{
"text": "HTTP {0} response from {1} in {2:.3f}s ({3})"
},
"critical": {
"text": "Connection failed to {1} ({3})"
}
}
}
}
]
}
Specifically lines:
"http":
"{{yarn-site/yarn.timeline-service.webapp.address}}/ws/v1/timeline",
"https":
"{{yarn-site/yarn.timeline-service.webapp.https.address}}/ws/v1/timeline",
These properties e.g. `yarn-site/yarn.timeline-service.webapp.address` are of
the form `host:port`. So the logic that adds http/https does not preserve that
the URL has `ws/v1/timeline` at the end.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 3f201c8
ambari-agent/src/test/python/ambari_agent/TestAlerts.py e5f6a41
ambari-agent/src/test/python/resource_management/TestGetPathFromUrl.py
PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py
1ab0ff1
ambari-common/src/main/python/resource_management/libraries/functions/get_path_from_url.py
PRE-CREATION
Diff: https://reviews.apache.org/r/45871/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
