-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45846/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15749
    https://issues.apache.org/jira/browse/AMBARI-15749


Repository: ambari


Description
-------

Introduce 'diff' post processing function to compute difference between points 
across time. 

Modify rate calculation such that it is calculated based on the precision of 
the data requested. When no explicit precision is requested from Grafana, the 
precision is computed based on this :

* Time_Range <= 2 hrs : Rate per SECOND 
* 2hrs < Time_Range <= 1 day : Rate per MINUTE . 
* 1 day < Time_Range <= 30 days : Rate per HOUR . 
* Time_Range > 30 days : Rate per DAY . 

Also, removed the first point from the series during rate and diff calculation.


Diffs
-----

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 a32e206 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/Function.java
 6f408a5 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/FunctionTest.java
 46bc6f8 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
 512a7db 

Diff: https://reviews.apache.org/r/45846/diff/


Testing
-------

Manually tested.

Added unit tests.


Thanks,

Aravindan Vijayan

Reply via email to