-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45928/
-----------------------------------------------------------
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-15719
https://issues.apache.org/jira/browse/AMBARI-15719
Repository: ambari
Description
-------
When a component is reassignable, the Ambari web UI adds the "Move" menu item
to the component menu on the host page.
The logic on whether a component should be displayed with the "Move" menu item
is currently controlled by the following hardcoded list.
/** @property
{Boolean}
isReassignable - component supports reassign action **/
isReassignable: function()
{ return ['NAMENODE', 'SECONDARY_NAMENODE', 'JOBTRACKER', 'RESOURCEMANAGER',
'APP_TIMELINE_SERVER', 'OOZIE_SERVER', 'WEBHCAT_SERVER', 'HIVE_SERVER',
'HIVE_METASTORE', 'MYSQL_SERVER',
'METRICS_COLLECTOR'].contains(this.get('componentName'));
}.property('componentName'),
We should make the list stack driven by specify whether a component is
reassignable via a flag in the metainfo.xml.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
b41ff09
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
301bfda
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
6b3ed76
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java
2205316
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
f8131c0
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
ebe0de8
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml
1f09364
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml
bd1b193
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/metainfo.xml
f1e377b
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml
1323e8d
ambari-server/src/main/resources/properties.json 627e22b
ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/YARN/metainfo.xml
64fab13
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/metainfo.xml
a508673
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml
eeb71fb
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
c79f9d2
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
a3d9655
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metainfo.xml
8ffd055
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml
35f77f8
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml
PRE-CREATION
ambari-web/app/mappers/stack_service_mapper.js b837452
ambari-web/app/models/stack_service_component.js 690c32f
ambari-web/test/mappers/stack_service_mapper_test.js 2f82bb1
ambari-web/test/service_components.js 614ffa8
Diff: https://reviews.apache.org/r/45928/diff/
Testing
-------
1. Added unit test for both frontend and backend code changes.
2. Patched a trunk cluster with code change and verified the Move menu item for
components was shown/hidden based on the flag set in the corresponding
metainfo.xml.
Thanks,
Di Li
