----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45924/#review127857 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/constants.py (line 79) <https://reviews.apache.org/r/45924/#comment191226> Nitpicking: Keep constant name and value the same (except for the case. RANGER_LOG4J_SUPPORT = "ranger_log4j_support" - Jayush Luniya On April 8, 2016, 11:20 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45924/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 11:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Nate Cole, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-15681 > https://issues.apache.org/jira/browse/AMBARI-15681 > > > Repository: ambari > > > Description > ------- > > **Problem Statement** > > Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot > be updated from Ambari. This forces the users to directly edit the > configuration file. > > **Proposed Solution** > Exposing log4j configurations for individual compomnents to Ambari as a > properties file. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 86dbc48 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 7201c36 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > c0ab3e8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 9544ee8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 03b7e01 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/45924/diff/ > > > Testing > ------- > > Verifed Ranger Admin and usersync log files being created based on configs > given in log4j.properties block from Ambari UI. > > > Thanks, > > Gautam Borad > >