-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45713/#review127996
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
76)
<https://reviews.apache.org/r/45713/#comment191397>

    Verify this change. If the hosts are being used to identify mapping of 
other components then its OK to ignore the ones in MM. Otherwise, the list may 
just be used to identify which host the components are mapped to - which should 
not ignore MM hosts.


- Sumit Mohanty


On April 8, 2016, 12:01 a.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45713/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 12:01 a.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-15700
>     https://issues.apache.org/jira/browse/AMBARI-15700
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-15700: Stack advisor - Component layout recommendation needs support 
> for avoiding hosts in maintenance mode
> 
> ** Issue **
> Stack advisor script should ignore hosts in maintenance mode when 
> recommending or validating component layout
> 
> ** Fix **
> Modified the stack advisor scripts to handle the case when one or more hosts 
> are in maintenance state while recommending or validating component layout
> Added two test cases to validate the recommendation when one or more hosts 
> are in maintenance state.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 53591cdcaed05713013be1ba7295b1c2b3ed64af 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483d3e1f08afe495fb30b6341f6f825f145d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a6554188939c4e0cdbb3d435ef29efc3d5e9376 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> b99c484b3e65de0c9186727064fc67a4bb1d8315 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 
> 636de01ad6fc72d9dc397b754aa5e190d4d9c5ff 
>   ambari-server/src/test/python/TestStackAdvisor.py 
> 149ae1dc7ea2e596680321dd70030dcfe060f6cf 
> 
> Diff: https://reviews.apache.org/r/45713/diff/
> 
> 
> Testing
> -------
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [8.744s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.041s]
> [INFO] Ambari Web ........................................ SUCCESS [25.392s]
> [INFO] Ambari Views ...................................... SUCCESS [1.375s]
> [INFO] Ambari Admin View ................................. SUCCESS [11.669s]
> [INFO] ambari-metrics .................................... SUCCESS [0.375s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.524s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.450s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.662s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.685s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.209s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [7.115s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.137s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [0.980s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:18.948s]
> [INFO] Ambari Server ..................................... SUCCESS [2:56.964s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [2.720s]
> [INFO] Ambari Agent ...................................... SUCCESS [24.955s]
> [INFO] Ambari Client ..................................... SUCCESS [0.045s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.838s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.152s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.054s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.719s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.118s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 5:54.648s
> [INFO] Finished at: Thu Apr 07 16:59:26 PDT 2016
> [INFO] Final Memory: 261M/1301M
> [INFO] 
> ------------------------------------------------------------------------
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> ----------------------------------------------------------------------
> Ran 253 tests in 6.689s
> 
> OK
> ----------------------------------------------------------------------
> Total run:944
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 54.377s
> [INFO] Finished at: Thu Apr 07 16:50:46 PDT 2016
> [INFO] Final Memory: 56M/1003M
> [INFO] 
> ------------------------------------------------------------------------
> 
> ** 3. mvn test -DskipPythonTests **
> 
> [ Tests are running. Will update this section once the results are available. 
> ]
> 
> ** 4. Manual tests **
> 
> Deployed a cluster with 3 VMs and modified stack_advisor.py scripts on the 
> host running ambari-server.
> 
> ** Regression testing **
> Tested the current behavior - all hosts are active.
> 
> ** Hosts in maintenance mode **
> Put 1 host in maintenance mode and verified that the components got 
> distributed across the remaining 2 hosts
> Put 2 hosts in maintenance mode and verified that all the components got 
> assigned to the only active host
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to