> On April 9, 2016, 4:15 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py, > > line 322 > > <https://reviews.apache.org/r/45980/diff/1/?file=1338258#file1338258line322> > > > > Shouldn't the same logic apply for HA scenario ? > > Andrew Onischuk wrote: > The code you pointed to is never used. > > Sumit Mohanty wrote: > The if-else section is bit longer than needed but we are now checking for > error only for HA. Did you mean should it be done in non-HA as well? > > The format_namenode() code needs some clean up. It does not seem that we > use "force=true" anywhere. > > Sid Wagle wrote: > In that case can we remove the code that is un-reachable?
didn't want to do much refactoring in 2.2.2 patch. Maybe let's change somewhere in 2.4.0? - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45980/#review127988 ----------------------------------------------------------- On April 9, 2016, 4:46 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45980/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 4:46 p.m.) > > > Review request for Ambari, Dmytro Sen and Sid Wagle. > > > Bugs: AMBARI-15789 > https://issues.apache.org/jira/browse/AMBARI-15789 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > 70e27a5 > > Diff: https://reviews.apache.org/r/45980/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
