-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46032/
-----------------------------------------------------------

(Updated April 11, 2016, 6:43 p.m.)


Review request for Ambari, Daniel Gergely, Laszlo Puskas, Robert Levas, Sandor 
Magyari, Srimanth Gunturi, and Sid Wagle.


Changes
-------

Added checks for NPE


Bugs: AMBARI-15803
    https://issues.apache.org/jira/browse/AMBARI-15803


Repository: ambari


Description
-------

After restart Ambari lazily loads persisted cluster state from database in 
order to figure out if there is anything pending for finalizing the cluster 
creation 
using Blueprints. The persisted host requests that don't have a host assigned 
yet (pending host request) the server has to assign hosts as they register with 
the server.

Due to bug the server was erroneously tracking which hosts to wait for to 
assign to the pending persisted host requests.
This led to NPEs later in the process of initializing state process database. 
Each host registration first checks if initialization from 
persisted state completed if not that triggers the initialization. Since the 
init was continuously failing it was re-triggered on each host 
registration leading to the unresponsiveness of the server.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
 82edbcf 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46032/diff/


Testing
-------

Manual testing using cluster creation templates with host groups with multiple 
hosts specified through fixed fqdn list and also host predicates.


Unit tests:
Results :

Tests run: 3550, Failures: 0, Errors: 0, Skipped: 36


Thanks,

Sebastian Toader

Reply via email to