-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45979/#review128252
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
 (line 56)
<https://reviews.apache.org/r/45979/#comment191667>

    That's correct, this constant was present in the code during some initial 
implementation work, to default to using the same host as AmbariServer to 
connect.
    
    This current patch already addresses that issue, however, please see:
    
    org.apache.ambari.server.controller.logging.LoggingRequestHelperFactoryImpl
    
    this factory class is the main entry point for creating the request helper 
instance, and uses the appropriate Ambari APIs in order to determine the 
connection information for the LogSearch service. 
    
    Thanks.



ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 (line 44)
<https://reviews.apache.org/r/45979/#comment191668>

    If there's a way to retrieve this via the current APIs, I'm happy to 
resolve that in a future patch, but I think using the constant is sufficient 
for now. 
    
    Thanks.


- Robert Nettleton


On April 11, 2016, 4:27 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45979/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 4:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-15807
>     https://issues.apache.org/jira/browse/AMBARI-15807
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logsearch support was splitted into 3 different commits: 
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
> - ambari server REST implementation for logsearch
> - stack definition
> 
> This one is the REST implementation. (by Robert Nettleton)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/LoggingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  c711bed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  371411d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  f24da8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  ca491f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/HostComponentLoggingInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogFileDefinitionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogFileType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogLineResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogQueryResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  63af4c4 
>   ambari-server/src/main/resources/key_properties.json 46a6cf9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogLineResultTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogQueryResponseTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45979/diff/
> 
> 
> Testing
> -------
> 
> Testing done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to