----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128373 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py (line 42) <https://reviews.apache.org/r/45978/#comment191812> See my comments on role command ordering for `logsearch.py`. Applies here as well. ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py (line 37) <https://reviews.apache.org/r/45978/#comment191809> According to the Role command order the `LOGSEARCH_SERVER` has a dependency on `LOGSEARCH_SOLR`. While there is cluster wide ordering for role commands when a cluster is deployed using the UI, there is only host level role command ordering is enforced when the cluster is provisioned using Blueprints. As such with Blueprints there is no guarantee that `LOGSEARCH_SOLR` is started before `LOGSEARCH_SERVER` if these are deployed to different hosts. If `{logsearch_dir}/run.sh {logsearch_ui_port}` has no built-in logic to check and wait until `LOGSEARCH_SOLR` comes up this logic needs to be added to `logsearch.py` ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py (line 41) <https://reviews.apache.org/r/45978/#comment191813> See my comments on role command ordering for `logsearch.py`. Applies here as well. - Sebastian Toader On April 11, 2016, 6:29 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45978/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 6:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and > Yusaku Sako. > > > Bugs: AMBARI-15806 > https://issues.apache.org/jira/browse/AMBARI-15806 > > > Repository: ambari > > > Description > ------- > > Logsearch support was splitted into 3 different commits: > https://github.com/apache/ambari/tree/branch-dev-logsearch > - integrate logsearch module > - ambari server REST implementation for logsearch > - stack definition > > This one is the stack definition. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > df46ce0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-atlas.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-falcon.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-kafka.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-knox.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-oozie.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ranger.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-storm.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-yarn.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-zookeeper.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/zoo.cfg.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 77ff982 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > 0ef4674 > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > 9ab413e > > ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > ed30846 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > 4731631 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > b53a090 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.4/configs/default.json PRE-CREATION > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 380fa39 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml > fb03cb3 > ambari-web/app/mappers/service_metrics_mapper.js 49f984d > ambari-web/app/models/quick_links.js d7fbbc6 > ambari-web/app/views/common/quick_view_link_view.js b62b7b8 > ambari-web/test/views/common/quick_link_view_test.js b9050f8 > > Diff: https://reviews.apache.org/r/45978/diff/ > > > Testing > ------- > > Total run:953 > Total errors:0 > Total failures:0 > > > Thanks, > > Oliver Szabo > >
