----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46144/#review128669 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On April 13, 2016, 1:54 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46144/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 1:54 p.m.) > > > Review request for Ambari and Alexandr Antonenko. > > > Bugs: AMBARI-15844 > https://issues.apache.org/jira/browse/AMBARI-15844 > > > Repository: ambari > > > Description > ------- > > Same named properties are currently disallowed for the same configType for a > given service, this jira proposes to display a warning to remind user the > existence of same-named properties for the service among all configTypes. > > > Diffs > ----- > > ambari-web/app/messages.js 2e4f648 > ambari-web/app/templates/common/configs/addPropertyWindow.hbs 61572fd > ambari-web/app/views/common/configs/service_configs_by_category_view.js > b5d5b45 > > Diff: https://reviews.apache.org/r/46144/diff/ > > > Testing > ------- > > patch a truck cluster with UI changes, > > 1. add "zookeeper.znode.parent" to hbase-site, notice the UI shows the error > message about the property is a dup. > This is to test the current error check still works. > > 2. add "zookeeper.znode.parent" to hbase-policy.xml, notice the UI shows a > warning this time, about a same-named property is defined in hbase-site.xml. > This is to test the new behavior introduced via this JIRA. > > > Thanks, > > Di Li > >
