----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128675 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On April 13, 2016, 2:28 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46147/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 2:28 p.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty. > > > Bugs: AMBARI-15861 > https://issues.apache.org/jira/browse/AMBARI-15861 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-15861. > > Last night's checkin of the initial LogSearch integration code in Ambari > caused a NullPointerException to occur in cluster deployments when LogSearch > is not available. Currently, that would account for most deployment attempts > on trunk, so this issue will block successful cluster deployments on trunk > until it is resolved. > > This patch implements the following > > 1. Adds a check for a null LoggingRequestHelper in the > LoggingSearchPropertyProvider implementation. > 2. Implements a new unit test to verify this fix. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > 6b4a8a4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java > 19c0756 > > Diff: https://reviews.apache.org/r/46147/diff/ > > > Testing > ------- > > 1. I manually verified that applying this fix to a trunk build will allow a > successful cluster deployment to occur, with no NullPointerExceptions > occurring, and I verified that the services started seem to be > installed/started as expected. > 2. Currently running ambari-server's "mvn clean test" suite, and will update > with results once that is completed. > > > Thanks, > > Robert Nettleton > >
