> On April 13, 2016, 4:50 a.m., Jayush Luniya wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 40 > > <https://reviews.apache.org/r/46127/diff/1/?file=1342184#file1342184line40> > > > > @Alejandro, lets talk about this before we make this change. Declaring > > this in service definition will be quite involved as we copy tarballs for > > components of other services. For example for hive we have code that copies > > mapreduce and tez tarball. > > > > > > ambari/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > > # if copy tarball to HDFS feature supported copy mapreduce.tar.gz > > and tez.tar.gz to HDFS > > if params.stack_version_formatted_major and > > check_stack_feature(StackFeature.COPY_TARBALL_TO_HDFS, > > params.stack_version_formatted_major): > > copy_to_hdfs("mapreduce", params.user_group, params.hdfs_user, > > host_sys_prepped=params.host_sys_prepped) > > copy_to_hdfs("tez", params.user_group, params.hdfs_user, > > host_sys_prepped=params.host_sys_prepped) > > > > Also, I have some changes pending to handle ambari-server upgrade to > > add these new properties. Once that done we will not need these static > > defaults in python file. By removing cluster-env config property we are > > reverted back to how it was in the past. So if a stack provider wants to > > place tarballs in HDFS to say /somebasepath/mapreduce/mapreduce.tar.gz, it > > won't be possible.
@Alejandro and I talked about this and for now I am ok with we moving back to python code as there isnt anyone asking for this fexibility for tarball map. I will look into adding stack-level config support rather than stack-version level config support where such properties can be defined. - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128610 ----------------------------------------------------------- On April 13, 2016, 1:03 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46127/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 1:03 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, > Nate Cole, and Swapan Shridhar. > > > Bugs: AMBARI-15850 > https://issues.apache.org/jira/browse/AMBARI-15850 > > > Repository: ambari > > > Description > ------- > > Hive Server Interactive is a new component and needs to be included in the > Rolling and Express Upgrades for HDP 2.5 to 2.5.* > > It also has instructions to restart LLAP app on Slider. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 2ba12b6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > 188f199 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > d909f6d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > f878141 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py > 9d5868b > ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 6be568b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json > b70af13 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > c05e33f > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > 5503c1a > > Diff: https://reviews.apache.org/r/46127/diff/ > > > Testing > ------- > > Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now. > > Python unit tests passed, > ---------------------------------------------------------------------- > Total run:952 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
