----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46159/#review128734 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java (line 161) <https://reviews.apache.org/r/46159/#comment192199> Is the version required in the XSD? Want to make sure this can't NPE out ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java (lines 18 - 19) <https://reviews.apache.org/r/46159/#comment192200> I'm LMAO at this. Can't believe the annotation doesn't support classes. - Jonathan Hurley On April 13, 2016, 2:53 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46159/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 2:53 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-15867 > https://issues.apache.org/jira/browse/AMBARI-15867 > > > Repository: ambari > > > Description > ------- > > When using a non-formatted VDF file with newlines in XML values, the newlines > are being preserved. This prevents repo files from being generated correctly. > > (Also noticed a test failure that was easy to fix and a visual issue whereby > non-manifest services like kerberos and AMS versions should be pulled from > the stack) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java > f855b05 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 4488f58 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 186ebe7 > > ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java > d262df3 > > Diff: https://reviews.apache.org/r/46159/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
