----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46181/ -----------------------------------------------------------
Review request for Ambari and Alexander Denissov. Bugs: AMBARI-15849 https://issues.apache.org/jira/browse/AMBARI-15849 Repository: ambari Description ------- Activate HAWQ standby wizard fails to delete previous hawq standby master. Currently, HAWQ standby status check is done based on the pid available in a directory. This directory is same for HAWQ master and HAWQ standby, thus if standby has been activated to active master, status of HAWQ Standby component still relies on the file and states it as running, and when an attempt is made to remove the standby component, it fails. Fixed the hawq component status derivation logic Diffs ----- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 2432df6 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 28946f1 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py c38e0de ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py a1b6dd9 Diff: https://reviews.apache.org/r/46181/diff/ Testing ------- Manually Tested. Ran unit tests: test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-13 16:36:49,436 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok ---------------------------------------------------------------------- Ran 34 tests in 0.357s OK Thanks, Matt