-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/#review128807
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
 (line 76)
<https://reviews.apache.org/r/46169/#comment192261>

    just dryRun will do


- Nate Cole


On April 13, 2016, 5:42 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46169/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 5:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15870
>     https://issues.apache.org/jira/browse/AMBARI-15870
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> To implement dry-run version of an API, request needs to be parsed manually 
> to figure out if request has dry-run directive.
> It will be good to add a method on Request object method itself which 
> centralizes parsing and logic for figuring out dry-run directive
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
>  12b91e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
>  f27f621 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  f8f8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
>  50eed9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  93fe36f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  633815e 
> 
> Diff: https://reviews.apache.org/r/46169/diff/
> 
> 
> Testing
> -------
> 
> Unit tests
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Reply via email to