-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
-----------------------------------------------------------


Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 92)
<https://reviews.apache.org/r/46186/#comment192275>

    Are the expected return values just 0 and 1?
    
    If yes, the function can have a name similar to  __is_process_running



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 96)
<https://reviews.apache.org/r/46186/#comment192277>

    You may use the component attribute map to get program_name or process_name.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 25)
<https://reviews.apache.org/r/46186/#comment192276>

    You may move this attribute map to hawq_constants if you think that is the 
right place.


- Matt


On April 13, 2016, 7:19 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 7:19 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
>     https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> -------
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Reply via email to