-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/
-----------------------------------------------------------

(Updated ápr. 14, 2016, 11:41 de)


Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Bugs: AMBARI-15862
    https://issues.apache.org/jira/browse/AMBARI-15862


Repository: ambari


Description
-------

When deleting a host, NPE may occur.
TopologyHostRequests are created with hostName=null at the first time, and when 
hosts are registered, then these null values are replaced with the correct host 
names.
In the case when a host is being deleted, a loop checks the host name for all 
the requests, and if there is a request with hostName=null, a NPE is thrown.
Swapping the sides of **equals** method can solve the problem, since the 
variable **hostname** is checked before and not null.

Lob and Basic annotations were removed, because that column in the database is 
not a CLOB. This turned out during running the test (in memory db is created 
based on these annotations).

The new test case adds hostRequests to the cluster, some of them have no host 
name (=null) to simulate hosts that have not registered to the cluster yet. If 
no exception is thrown when deleting a registered host, then it is successful.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
 0a81286 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 c5554f7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 daf8d12 

Diff: https://reviews.apache.org/r/46148/diff/


Testing (updated)
-------

Branch 2.2.2

Results :

Tests run: 3553, Failures: 0, Errors: 0, Skipped: 36

...

Total run:925
Total errors:0
Total failures:0

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:11:47.762s
[INFO] Finished at: Thu Apr 14 13:40:06 CEST 2016
[INFO] Final Memory: 46M/1060M
[INFO] ------------------------------------------------------------------------


Thanks,

Daniel Gergely

Reply via email to