-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46195/#review128878
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On April 14, 2016, 11:29 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46195/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 11:29 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15880
>     https://issues.apache.org/jira/browse/AMBARI-15880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> yarn-env had an issue where ATS heapsize was not getting set correctly
> This was fixed in Ambari-2.1.0 for HDP 2.2 and Ambari-2.2.1.1 for HDP 
> 2.3/2.4.  
> However, "ambari-server upgrade" does not fix yarn-env, even if the user has
> never touched it.
> 
> STR:
> 
>   * Install a HDP 2.4.0 cluster with YARN using Ambari 2.2.1.0
>   * Confirm that yarn-env has **export 
> YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`** (this is incorrect)
>   * ambari-server stop
>   * Install ambari.repo for Ambari 2.2.1.1
>   * yum upgrade ambari-server
>   * ambari-server upgrade
>   * ambari-server start
> 
> Actual: yarn-env still has **export
> YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`**  
> Expected: yarn-env has **export
> YARN_TIMELINESERVER_HEAPSIZE=`apptimelineserver_heapsize`** instead
> 
> This means that changing "AppTimelineServer Java heap size" from the UI has no
> effect on setting the actual heapsize for ATS.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  31af5e3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  59f9f91 
> 
> Diff: https://reviews.apache.org/r/46195/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to