-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128996
-----------------------------------------------------------


Ship it!




Ship It!

- Jaimin Jetly


On April 14, 2016, 8:56 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:56 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
>     https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to