> On April 14, 2016, 11 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py, > > line 26 > > <https://reviews.apache.org/r/46186/diff/3/?file=1345552#file1345552line26> > > > > do we need unit test for this function ?
will add unit test. > On April 14, 2016, 11 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py, > > line 46 > > <https://reviews.apache.org/r/46186/diff/1-3/?file=1343693#file1343693line46> > > > > variable is not used anywhere else other than the line below, can > > probably inline it for brevity will do - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review129024 ----------------------------------------------------------- On April 14, 2016, 9:20 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46186/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 9:20 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15852 > https://issues.apache.org/jira/browse/AMBARI-15852 > > > Repository: ambari > > > Description > ------- > > HAWQ restart after port change will fail because Ambari looks for a currently > running process with a new port number. > This change is to make Ambari to look for an older port value. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 413cf1a > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 3f6c371 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > f2ec914 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py > 636dcad > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 67d1cb0 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py > 92ac0af > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > 0baa4c5 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 > > Diff: https://reviews.apache.org/r/46186/diff/ > > > Testing > ------- > > Unit test has passed. > Manual Test in progress. > > > Thanks, > > jun aoki > >
