----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46247/#review129112 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On April 14, 2016, 10:31 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46247/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 10:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, > Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-15903 > https://issues.apache.org/jira/browse/AMBARI-15903 > > > Repository: ambari > > > Description > ------- > > 1) Some are showing params that should be hidden > 2) Some need new display labels > 3) Some need hover tooltip description text > 4) Some need alert description tweaks > 5) In the hive alerts, some of those params, missing thresholds > > > Diffs > ----- > > ambari-server/src/main/resources/alerts.json 0bbd004 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json > 4dc52a2 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json > 1f86e57 > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 9dc4f92 > ambari-web/app/models/alerts/alert_definition.js 245771e > > Diff: https://reviews.apache.org/r/46247/diff/ > > > Testing > ------- > > ambari-server: > All alert unit test passed. > mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false > ambari-web: > All UT passed > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
