-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46280/#review129190
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (lines 2257 - 2262)
<https://reviews.apache.org/r/46280/#comment192649>

    OMG, seriously. How many places do we need to intercept commands and inject 
stuff. Nice find!


- Jonathan Hurley


On April 15, 2016, 5:13 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46280/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15929
>     https://issues.apache.org/jira/browse/AMBARI-15929
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When an upgrade is suspended, the user can initiate any command.  Issuing a 
> START against a client actually invokes INSTALL.  When that happens, the 
> after-INSTALL hook will execute {{hdp-select set all}}.  Check to see if the 
> upgrade is suspended before making that call.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  9870441 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  7b51fc0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  b188c16 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  955404c 
> 
> Diff: https://reviews.apache.org/r/46280/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> ----------------------------------------------------------------------
> Total run:960
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Reply via email to