----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46137/#review129378 -----------------------------------------------------------
Ship it! - Alejandro Fernandez On April 18, 2016, 5:39 p.m., Nahappan Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46137/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 5:39 p.m.) > > > Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and > Sid Wagle. > > > Bugs: AMBARI-15814 > https://issues.apache.org/jira/browse/AMBARI-15814 > > > Repository: ambari > > > Description > ------- > > AMBARI-15814: Enable debugging of ambari-server upgrade command > > ** Issue **: > Right now **ambari-server upgrade** cannot be debugged remotely. To enable > remote debugging, handle the -g/--debug flag the same way **ambari-server > start -g** works. > > ** Fix **: > Create a debug command line for JVM to execute, the same way as ambari-server > start -g works. > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 > > Diff: https://reviews.apache.org/r/46137/diff/ > > > Testing > ------- > > ** 1. mvn clean install ** > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [7.946s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.036s] > [INFO] Ambari Web ........................................ SUCCESS [39.154s] > [INFO] Ambari Views ...................................... SUCCESS [1.073s] > [INFO] Ambari Admin View ................................. SUCCESS [8.779s] > [INFO] ambari-metrics .................................... SUCCESS [0.356s] > [INFO] Ambari Metrics Common ............................. SUCCESS [0.467s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.190s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.633s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.645s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.640s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [6.663s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.831s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [0.896s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:18.645s] > [INFO] Ambari Server ..................................... SUCCESS [2:49.890s] > [INFO] Ambari Functional Tests ........................... SUCCESS [2.347s] > [INFO] Ambari Agent ...................................... SUCCESS [24.663s] > [INFO] Ambari Client ..................................... SUCCESS [0.045s] > [INFO] Ambari Python Client .............................. SUCCESS [0.983s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.203s] > [INFO] Ambari Shell ...................................... SUCCESS [0.041s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.720s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [0.966s] > [INFO] ambari-logsearch .................................. SUCCESS [0.288s] > [INFO] Ambari Logsearch Portal ........................... SUCCESS [8.111s] > [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [3.025s] > [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.216s] > [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.089s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 6:07.410s > [INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016 > [INFO] Final Memory: 281M/1155M > [INFO] > ------------------------------------------------------------------------ > > ** 2. mvn test -DskipSurefireTests ** > > ---------------------------------------------------------------------- > Ran 260 tests in 6.521s > > OK > ---------------------------------------------------------------------- > Total run:963 > Total errors:0 > Total failures:0 > OK > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 52.557s > [INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016 > [INFO] Final Memory: 56M/1024M > [INFO] > ------------------------------------------------------------------------ > > > ** 3. Manual testing ** > > Ran *ambari-server upgrade -g* and verified that intelliJ debugger could be > attached to the remote process. > > > Thanks, > > Nahappan Somasundaram > >
